Skip to content

Conversation

daflack
Copy link
Contributor

@daflack daflack commented Sep 2, 2025

Add a diagnostic for probability without the control member for temperature at screen level alongside changes to collapse.py to ensure the probability works.

Fixes #1644

Contribution checklist

Aim to have all relevant checks ticked off before merging. See the developer's guide for more detail.

  • Documentation has been updated to reflect change.
  • New code has tests, and affected old tests have been updated.
  • All tests and CI checks pass.
  • Ensured the pull request title is descriptive.
  • Conda lock files have been updated if dependencies have changed.
  • Attributed any Generative AI, such as GitHub Copilot, used in this PR.
  • Marked the PR as ready to review.

@daflack daflack self-assigned this Sep 2, 2025
Copy link
Contributor

github-actions bot commented Sep 2, 2025

Coverage

@daflack daflack changed the title Add ensemble probability without control member diagnostic Add ensemble probability without control member diagnostic for temperature at screen level Sep 3, 2025
@daflack daflack force-pushed the probability_without_control branch 4 times, most recently from 36cfabc to 9dd4a40 Compare September 8, 2025 07:51
@daflack
Copy link
Contributor Author

daflack commented Sep 8, 2025

Evidence of it working:
image
image
image

@daflack daflack marked this pull request as ready for review September 8, 2025 08:54
@daflack daflack force-pushed the probability_without_control branch from c5937d3 to 75401c9 Compare September 8, 2025 12:52
@daflack daflack force-pushed the probability_without_control branch from 75401c9 to 60fcc2d Compare September 9, 2025 12:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Ensemble probabilities (not including control member) for temperature at screen level
1 participant