Skip to content

Add diagnostic for daily maximum temperature between 0900 UTC and 0900 UTC #1622

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 15 commits into from
Sep 9, 2025
Merged

Add diagnostic for daily maximum temperature between 0900 UTC and 0900 UTC #1622

merged 15 commits into from
Sep 9, 2025

Conversation

daflack
Copy link
Contributor

@daflack daflack commented Aug 22, 2025 •
edited
Loading

Add a diagnostic for daily maximum temperature between 0900 UTC and 0900 UTC. It utilises rolling_window aggregation and creates a new constraint based on hour of day, alongside recipes for the daily maximum temperature.

Fixes #1552

Contribution checklist

Aim to have all relevant checks ticked off before merging. See the developer's guide for more detail.

  • Documentation has been updated to reflect change.
  • New code has tests, and affected old tests have been updated.
  • All tests and CI checks pass.
  • Ensured the pull request title is descriptive.
  • Conda lock files have been updated if dependencies have changed.
  • Attributed any Generative AI, such as GitHub Copilot, used in this PR.
  • Marked the PR as ready to review.

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Aug 22, 2025 •
edited
Loading

Coverage

@daflack daflack force-pushed the daily_max_temperature branch 3 times, most recently from 5481774 to ab0a6d5 Compare September 2, 2025 07:20
@daflack daflack self-assigned this Sep 2, 2025
@daflack daflack added the enhancement New feature or request label Sep 3, 2025
@daflack daflack force-pushed the daily_max_temperature branch 2 times, most recently from deb3e18 to 3c0f565 Compare September 5, 2025 11:11
@daflack
Copy link
Contributor Author

daflack commented Sep 5, 2025

Evidence - spatial plot:
image
Difference (note same model used due to output - so a result of zero across the board is expected):
image

@daflack daflack marked this pull request as ready for review September 5, 2025 13:42
@daflack daflack force-pushed the daily_max_temperature branch from ee382e4 to 068afd1 Compare September 8, 2025 12:52
Sylviabohnenstengel
Sylviabohnenstengel approved these changes Sep 8, 2025
View reviewed changes
Copy link
Contributor

@Sylviabohnenstengel Sylviabohnenstengel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

only minor comments. Happy to approve.

@Sylviabohnenstengel
Copy link
Contributor

@daflack approved subject to minor comments.

@daflack daflack force-pushed the daily_max_temperature branch from 24dbe14 to abf5394 Compare September 9, 2025 12:21
@daflack daflack merged commit 25c37b2 into main Sep 9, 2025
8 checks passed
@daflack daflack deleted the daily_max_temperature branch September 9, 2025 12:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Sylviabohnenstengel Sylviabohnenstengel Sylviabohnenstengel approved these changes

Assignees

@daflack daflack

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Daily Maximum Temperature
2 participants
@daflack @Sylviabohnenstengel