Skip to content

Wrong type on OlSourceVector.features #399

@azygis

Description

@azygis

Describe the bug
The type on features prop of OlSourceVector is wrong (or incomplete). Currently it accepts array / collection of Geometry but it should be Feature or even FeatureLike. This forces us to add nasty hacks like const realFeatures = computed(() => features.value as unknown as Geometry[]); and passing that instead.

Affected version(s)

Pretty sure all version up until now.

To Reproduce
N/A

Expected behavior
Above.

Screenshots
N/A

Desktop (please complete the following information):
N/A

Smartphone (please complete the following information):
N/A

Additional context
I can create a pull request with the change but I'm not sure if it will become a breaking change or not. Would like to know if it was an oversight or an intentional implementation.

Metadata

Metadata

Assignees

No one assigned

    Labels

    bugSomething isn't working

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions