fix(storage): fix incorrect mtime by UTC offset #106
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
IlyaFaer
approved these changes
Jan 29, 2020
|
|
||
|
|
||
| def _convert_to_timestamp(value): | ||
| """Convert non-none datetime to timestamp. |
Collaborator
Author
Owner
There was a problem hiding this comment.
I tend to agree with both of you. While certainly grammatically incorrect, we might want to make no changes and let this to be dealt with later.
MaxxleLLC
approved these changes
Jan 29, 2020
|
|
||
|
|
||
| def _convert_to_timestamp(value): | ||
| """Convert non-none datetime to timestamp. |
Owner
There was a problem hiding this comment.
I tend to agree with both of you. While certainly grammatically incorrect, we might want to make no changes and let this to be dealt with later.
…_mtime_download_file
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
IPR [10214]