refactor(bigquery): update code sample of quey job #104
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
IlyaFaer
reviewed
Jan 24, 2020
Collaborator
IlyaFaer
left a comment
IlyaFaer
left a comment
There was a problem hiding this comment.
Couple nits. Tim can ask to delete excess variables,. So I would got rid of them
bigquery/docs/usage/jobs.rst
Outdated
| :start-after: [START bigquery_get_job] | ||
| :end-before: [END bigquery_get_job] | ||
|
|
||
| CancelJob |
Collaborator
There was a problem hiding this comment.
Looks like whitespace lost in here
bigquery/samples/cancel_job.py
Outdated
| """ | ||
| location = "us" | ||
| job = client.query(sql, location=location) | ||
| job_id = job.job_id |
Collaborator
There was a problem hiding this comment.
This variable looks excess. It used only once, and it won't be changed within cancel_job() method
bigquery/samples/get_job.py
Outdated
| """ | ||
| location = "us" | ||
| job = client.query(sql, location=location) | ||
| job_id = job.job_id |
mf2199
approved these changes
Jan 24, 2020
Collaborator
mf2199
left a comment
mf2199
left a comment
There was a problem hiding this comment.
Some really minor things but otherwise OK.
bigquery/samples/cancel_job.py
Outdated
| """ | ||
| location = "us" | ||
| job = client.query(sql, location=location) | ||
|
|
Collaborator
There was a problem hiding this comment.
A nit: Even though it's probably copied from the original, I'm not sure if this blank line makes much sense.
bigquery/samples/get_job.py
Outdated
Comment on lines
31
to
34
|
|
||
| job = client.get_job(job.job_id, location=location) # Make an API request. | ||
| print("Details for job {} running in {}:".format(job.job_id, location)) | ||
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Towards [8989]
List of changes