catalog-protos: remove protobuf dependency #33848
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
teskje
force-pushed
the
catalog-remove-protobuf
branch
from
382caf3 to
1eb4f73
Compare
antiguru
approved these changes
Dec 9, 2025
Member
antiguru
left a comment
antiguru
left a comment
There was a problem hiding this comment.
Looks good! Do you mind filing an issue to add documentation to this crate? The catalog types would greatly benefit from some documentation.
teskje
force-pushed
the
catalog-remove-protobuf
branch
5 times, most recently
from
96ce99d to
6c18d2b
Compare
This commit adds Rust source files describing the existing versioned catalog definitions. The contained types are generated by running the protobuf codegen and then cleaning up the result. They have the same fields and JSON serialization behavior as the proto types, but don't depend on `prost`.
This commit changes the existing hash checking logic meant to ensure that the versioned proto files never change to check the new Rust source files instead.
This commit removes the now unused proto definitions and cleans up the crate dependencies.
teskje
force-pushed
the
catalog-remove-protobuf
branch
from
6c18d2b to
6d93396
Compare
Contributor
Author
|
TFTR! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR replaces the proto definitions in
mz-catalog-protoswith the equivalent Rust type definitions, obtained through protobuf codegen and subsequent cleanup. This removes the dependency onprostand paves the way for removing one level ofStateUpdateKinddefinitions.Note that the crate is still called
mz-catalog-protosand there are plenty of references to "protos" left in other crates. Cleaning this up is left as a follow-up.Motivation
Step (2) of https://github.com/MaterializeInc/database-issues/issues/9792
Tips for reviewer
Checklist
$T ⇔ Proto$Tmapping (possibly in a backwards-incompatible way), then it is tagged with aT-protolabel.