Skip to content

always use complete path as index lookup #304

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
s4c5 wants to merge 2 commits into from
Closed

always use complete path as index lookup #304

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d3a3bce
Misc
MaskRay Mar 3, 2019
e2a4a5f
always use complete path as index lookup
s4c5 Mar 5, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,6 @@ cquery has system include path detection (through running the compiler driver) w
# >>> [Getting started](../../wiki/Home) (CLICK HERE) <<<

* [Build](../../wiki/Build)
* [Client feature table](../../wiki/Client-feature-table)
* [FAQ](../../wiki/FAQ)

ccls can index itself (~180MiB RSS when idle, noted on 2018-09-01), FreeBSD, glibc, Linux, LLVM (~1800MiB RSS), musl (~60MiB RSS), ... with decent memory footprint. See [wiki/compile_commands.json](../../wiki/compile_commands.json) for examples.
3 changes: 2 additions & 1 deletion src/indexer.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -473,7 +473,8 @@ class IndexDataConsumer : public index::IndexDataConsumer {
info.usr = HashUsr(USR);
if (auto *ND = dyn_cast<NamedDecl>(D)) {
info.short_name = ND->getNameAsString();
info.qualified = ND->getQualifiedNameAsString();
llvm::raw_string_ostream OS(info.qualified);
ND->printQualifiedName(OS, GetDefaultPolicy());
SimplifyAnonymous(info.qualified);
}
}
Expand Down
12 changes: 11 additions & 1 deletion src/utils.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -113,7 +113,17 @@ std::string LowerPathIfInsensitive(const std::string &path) {
c = tolower(c);
return ret;
#else
return path;
// use this opportunity to get full path
char *rpbuf = NULL;
std::string fullpath;
rpbuf = realpath(path.c_str(), NULL);
Copy link

@myrgy myrgy Mar 6, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would say that since project is based on c++17 it worth to use std::filesystem

https://en.cppreference.com/w/cpp/filesystem/absolute

if (rpbuf != NULL) {
fullpath = rpbuf;
free(rpbuf);
} else {
fullpath = path;
}
return fullpath;
#endif
}

Expand Down