Skip to content

Conversation

davidsharp7
Copy link
Member

@davidsharp7 davidsharp7 commented Jul 19, 2024

Problem

Currently we are returning the top 100 versions of a dataset. This PR is to implement paging so that users can cycle through dataset versions.

Closes: #2842

Solution

Adding paging similar to the job versions paging.

Screenshot 2024-07-19 at 19 14 55

Add totalCount to dataset versions payload

Screenshot 2024-07-19 at 19 23 38

One-line summary:

Add datasets paging

Checklist

  • You've signed-off your work
  • Your changes are accompanied by tests (if relevant)
  • Your change contains a small diff and is self-contained
  • You've updated any relevant documentation (if relevant)
  • You've included a one-line summary of your change for the CHANGELOG.md (Depending on the change, this may not be necessary).
  • You've versioned your .sql database schema migration according to Flyway's naming convention (if relevant)
  • You've included a header in any source code files (if relevant)

@boring-cyborg boring-cyborg bot added api API layer changes web labels Jul 19, 2024
Copy link

netlify bot commented Jul 19, 2024

Deploy Preview for peppy-sprite-186812 canceled.

Name Link
🔨 Latest commit 31dba43
🔍 Latest deploy log https://app.netlify.com/sites/peppy-sprite-186812/deploys/669f541c4f792200082d69b6

Signed-off-by: sharpd <[email protected]>
Copy link

codecov bot commented Jul 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.75%. Comparing base (2015c39) to head (31dba43).

Additional details and impacted files
@@            Coverage Diff            @@
##               main    #2855   +/-   ##
=========================================
  Coverage     84.74%   84.75%           
  Complexity     1456     1456           
=========================================
  Files           253      253           
  Lines          6563     6566    +3     
  Branches        305      305           
=========================================
+ Hits           5562     5565    +3     
  Misses          850      850           
  Partials        151      151           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: sharpd <[email protected]>
Copy link
Member

@phixMe phixMe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good to me, thanks so much for this!

@davidsharp7 davidsharp7 marked this pull request as ready for review July 21, 2024 05:20
@davidsharp7 davidsharp7 merged commit 879031a into main Jul 23, 2024
@davidsharp7 davidsharp7 deleted the web/add_paging_dataset_version_hist branch July 23, 2024 07:07
jonathanpmoraes pushed a commit to nubank/NuMarquez that referenced this pull request Feb 6, 2025
* initial commit of dataset paging

Signed-off-by: sharpd <[email protected]>

* fix linting

Signed-off-by: sharpd <[email protected]>

* remove system.out

Signed-off-by: sharpd <[email protected]>

* add dataset versions count test

Signed-off-by: sharpd <[email protected]>

* remove system print

Signed-off-by: sharpd <[email protected]>

---------

Signed-off-by: sharpd <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api API layer changes web
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Dataset and job panels do not page for versions and run history respectively
2 participants