-
Notifications
You must be signed in to change notification settings - Fork 369
Add paging to dataset versions panel #2855
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: sharpd <[email protected]>
✅ Deploy Preview for peppy-sprite-186812 canceled.
|
Signed-off-by: sharpd <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2855 +/- ##
=========================================
Coverage 84.74% 84.75%
Complexity 1456 1456
=========================================
Files 253 253
Lines 6563 6566 +3
Branches 305 305
=========================================
+ Hits 5562 5565 +3
Misses 850 850
Partials 151 151 ☔ View full report in Codecov by Sentry. |
Signed-off-by: sharpd <[email protected]>
phixMe
approved these changes
Jul 19, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes look good to me, thanks so much for this!
Signed-off-by: sharpd <[email protected]>
jonathanpmoraes
pushed a commit
to nubank/NuMarquez
that referenced
this pull request
Feb 6, 2025
* initial commit of dataset paging Signed-off-by: sharpd <[email protected]> * fix linting Signed-off-by: sharpd <[email protected]> * remove system.out Signed-off-by: sharpd <[email protected]> * add dataset versions count test Signed-off-by: sharpd <[email protected]> * remove system print Signed-off-by: sharpd <[email protected]> --------- Signed-off-by: sharpd <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Currently we are returning the top 100 versions of a dataset. This PR is to implement paging so that users can cycle through dataset versions.
Closes: #2842
Solution
Adding paging similar to the job versions paging.
Add totalCount to dataset versions payload
One-line summary:
Add datasets paging
Checklist
CHANGELOG.md
(Depending on the change, this may not be necessary)..sql
database schema migration according to Flyway's naming convention (if relevant)