Skip to content

Web: Source Code Facets #2833

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jun 5, 2024
Merged

Web: Source Code Facets #2833

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
137153c
Adding source code facets.
Jun 4, 2024
25f988f
Adding source code facets.
Jun 4, 2024
89aae6d
Merge remote-tracking branch 'origin/fix/source-code-facets' into fix…
Jun 5, 2024
454dfe4
Merge branch 'main' into fix/source-code-facets
phixMe Jun 5, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions web/src/components/core/code/MqCode.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,9 @@ interface OwnProps {
}

const MqCode: React.FC<OwnProps> = ({ code, description, language }) => {
if (!code) {
return null
}
return (
<Box>
{description && (
Expand Down
13 changes: 13 additions & 0 deletions web/src/components/jobs/RunInfo.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,6 +28,13 @@ export interface SqlFacet {
query: string
}

export interface SourceCodeFacet {
language: string
sourceCode: string
_producer: string
_schemaURL: string
}

type RunInfoProps = {
run: Run
} & JobFacetsProps &
Expand All @@ -52,6 +59,12 @@ const RunInfo: FunctionComponent<RunInfoProps> = (props) => {
return (
<Box>
{<MqCode code={(jobFacets?.sql as SqlFacet)?.query} language={'sql'} />}
{
<MqCode
code={(jobFacets.sourceCode as SourceCodeFacet)?.sourceCode}
language={(jobFacets.sourceCode as SourceCodeFacet)?.language}
/>
}
{run.facets && (
<Box mt={2}>
<Box mb={1}>
Expand Down