Skip to content

Conversation

davidsharp7
Copy link
Member

@davidsharp7 davidsharp7 commented Dec 26, 2023

Problem

Currently you can only add/delete tags at the dataset level via the API. It would be useful to be able to do this via the UI.

Closes: #2668

Solution

One-line summary:

Add dataset tags component so that datasets can have tags added/deleted.

Checklist

  • You've signed-off your work
  • Your changes are accompanied by tests (if relevant)
  • Your change contains a small diff and is self-contained
  • You've updated any relevant documentation (if relevant)
  • You've included a one-line summary of your change for the CHANGELOG.md (Depending on the change, this may not be necessary).
  • You've versioned your .sql database schema migration according to Flyway's naming convention (if relevant)
  • You've included a header in any source code files (if relevant)

@boring-cyborg boring-cyborg bot added the web label Dec 26, 2023
Copy link

netlify bot commented Dec 26, 2023

Deploy Preview for peppy-sprite-186812 canceled.

Name Link
🔨 Latest commit 2ce49ab
🔍 Latest deploy log https://app.netlify.com/sites/peppy-sprite-186812/deploys/65907ed1f9ee9c0008c17e24

Copy link

codecov bot commented Dec 26, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (f3c3057) 84.42% compared to head (2ce49ab) 84.42%.
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##               main    #2714   +/-   ##
=========================================
  Coverage     84.42%   84.42%           
  Complexity     1416     1416           
=========================================
  Files           251      251           
  Lines          6434     6434           
  Branches        291      291           
=========================================
  Hits           5432     5432           
  Misses          850      850           
  Partials        152      152           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@davidsharp7 davidsharp7 marked this pull request as ready for review December 26, 2023 20:41
@wslulciuc wslulciuc added this to the 0.44.0 milestone Dec 30, 2023
Copy link
Member

@wslulciuc wslulciuc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I did a quick scan of the UI code, and looks straightforward. Great work to also add support for add/delete tag functionality to the UI @davidsharp7.

@phixMe, I'm going to merge as I'm refactoring our services and want to avoid merge conflicts. But, let's address any feedback as follow up work when we're all back from the holidays.

@wslulciuc wslulciuc enabled auto-merge (squash) December 30, 2023 20:34
@wslulciuc wslulciuc merged commit 04fc7b7 into MarquezProject:main Dec 30, 2023
@davidsharp7 davidsharp7 deleted the web/add_tags_to_datasets_via_ui branch December 31, 2023 00:10
jonathanpmoraes pushed a commit to nubank/NuMarquez that referenced this pull request Feb 6, 2025
* add dataset tags tabs for add/delete of tags.

Signed-off-by: sharpd <[email protected]>

* fix failing dataset test

Signed-off-by: sharpd <[email protected]>

---------

Signed-off-by: sharpd <[email protected]>
Co-authored-by: sharpd <[email protected]>
Co-authored-by: Willy Lulciuc <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Add/delete tags to a dataset via the UI
2 participants