Skip to content

Conversation

sophiely
Copy link
Contributor

@sophiely sophiely commented Jun 27, 2023

Problem

DataQualityAssertion facet are not displayed anymore du to the recent changes where we only display type: dataset and unknown.

Closes: #2503

Solution

We can display dataset of type dataset, unknown and input.

Checklist

  • You've signed-off your work
  • Your changes are accompanied by tests
  • Your change contains a small diff and is self-contained (not relevant here)
  • You've updated any relevant documentation (not relevant here)
  • You've included a one-line summary of your change for the CHANGELOG.md (Depending on the change, this may not be necessary).
  • You've versioned your .sql database schema migration according to Flyway's naming convention (if relevant)
  • You've included a header in any source code files (if relevant)

@boring-cyborg boring-cyborg bot added the api API layer changes label Jun 27, 2023
@boring-cyborg
Copy link

boring-cyborg bot commented Jun 27, 2023

Thanks for opening your first pull request in the Marquez project! Please check out our contributing guidelines (https://github.com/MarquezProject/marquez/blob/main/CONTRIBUTING.md).

Signed-off-by: sophiely <[email protected]>
@sophiely sophiely force-pushed the fix/issue-2503-display-dataquality-assertition-facets branch from cbc2ddd to 2fa5249 Compare June 27, 2023 14:27
@boring-cyborg boring-cyborg bot added the docs label Jul 10, 2023
@sophiely sophiely force-pushed the fix/issue-2503-display-dataquality-assertition-facets branch from 87915ae to 2fa5249 Compare July 10, 2023 17:38
@dkt-sophie-ly
Copy link

Is the assertion supposed to be like this without the DataQualityAssertion or it is a mistake ?

@wslulciuc wslulciuc added the bug Something isn't working label Nov 28, 2023
@wslulciuc wslulciuc added this to the Roadmap milestone Nov 28, 2023
Copy link
Member

@wslulciuc wslulciuc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @sophiely! CI is failing, but I'll look into that.

Copy link

netlify bot commented May 7, 2024

Deploy Preview for peppy-sprite-186812 canceled.

Name Link
🔨 Latest commit a003fe2
🔍 Latest deploy log https://app.netlify.com/sites/peppy-sprite-186812/deploys/66399b1e6f7cd30008221c66

@wslulciuc wslulciuc merged commit 71f454a into MarquezProject:main May 7, 2024
@wslulciuc wslulciuc modified the milestones: Roadmap, 0.47.0 May 7, 2024
@sophiely sophiely deleted the fix/issue-2503-display-dataquality-assertition-facets branch July 25, 2024 07:45
jonathanpmoraes pushed a commit to nubank/NuMarquez that referenced this pull request Feb 6, 2025
Signed-off-by: sophiely <[email protected]>
Co-authored-by: Willy Lulciuc <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api API layer changes bug Something isn't working docs
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

[Bug] facet dataQualityAssertions is not displayed since 0.33.0
3 participants