Migration script and DAO updates for job renaming and symlinking #1947
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Michael Collado <[email protected]>
Signed-off-by: Michael Collado <[email protected]>
Signed-off-by: Michael Collado <[email protected]>
Signed-off-by: Michael Collado <[email protected]>
collado-mike
changed the title
Codecov Report
@@ Coverage Diff @@
## main #1947 +/- ##
=========================================
Coverage 78.09% 78.09%
- Complexity 944 945 +1
=========================================
Files 193 193
Lines 5249 5251 +2
Branches 418 418
=========================================
+ Hits 4099 4101 +2
Misses 705 705
Partials 445 445
📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more |
wslulciuc
reviewed
Apr 19, 2022
| public static final String SCHEMA_LOCATION = "schema_location"; | ||
|
|
||
| /* JOB ROW COLUMNS */ | ||
| public static final String SYMLINK_TARGET_UUID = "symlink_target_uuid"; |
There was a problem hiding this comment.
Just a note, I can imagine the renaming of datasets also requiring a symlink target column.
wslulciuc
approved these changes
Apr 20, 2022
There was a problem hiding this comment.
Being able to rename jobs using symlinks has been on the roadmap for a while! Great work, @collado-mike! Also, thanks for being so thorough with testing 💯 🥇
jonathanpmoraes
pushed a commit
to nubank/NuMarquez
that referenced
this pull request
Feb 6, 2025
…quezProject#1947) * Add migration script to create job symlink target Signed-off-by: Michael Collado <[email protected]> * Update JobDao to find job symlink targets and add tests Signed-off-by: Michael Collado <[email protected]> * Update RunDao to fetch runs for jobs with symlinks Signed-off-by: Michael Collado <[email protected]> * Update changelog Signed-off-by: Michael Collado <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Part one of #1946
Implements the migration script and changes to
JobDaoandRunDaoto support symlinked jobs.Checklist
CHANGELOG.mdwith details about your change under the "Unreleased" section (if relevant, depending on the change, this may not be necessary).sqldatabase schema migration according to Flyway's naming convention (if relevant)