Skip to content

Fix running tests on Linux and macOS #28

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix running tests on Linux and macOS #28

wants to merge 1 commit into from

Conversation

0xced
Copy link

@0xced 0xced commented Nov 30, 2024

  • BlurhasherTests requires Path.Combine instead of hardcoded \ path separator.
  • ImageConversionTest requires all tests to be skipped on non-Windows platforms because System.Drawing is only available on Windows (it throws PlatformNotSupportedException).

@0xced
Fix running tests on Linux and macOS
e141952 
* BlurhasherTests requires `Path.Combine` instead of hardcoded \ path separator.
* ImageConversionTest requires all tests to be skipped on non-Windows platforms because `System.Drawing` is only available on Windows (it throws `PlatformNotSupportedException`).
@0xced 0xced mentioned this pull request Nov 30, 2024
Merged
@0xced
Copy link
Author

0xced commented Apr 17, 2025

Hey Markus,
Just a quick reminder to take a look at that pull request when you get a chance. No rush, I just wanted to make sure it didn’t slip through the cracks. Let me know if you have any questions or need anything from me.

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@0xced