Bump node-sass version to v4.0.0 #121
Conversation
Current node-sass version is too low for it to build on Windows
|
Was something breaking previously for our builds? I wasn't aware that node-sass was broken. |
|
Works fine for me node-sass requires the native c/c++ build tools to work. or you can manually install here https://github.com/nodejs/node-gyp |
I did a clean install of nodejs and it still doesn't build, probably because you already have a higher version of node-sass cached in npm and in vue-strap's There are similar problems as well: |
There was a problem hiding this comment.
Ok, can confirm on a clean Windows installation that the build fails. It is likely due to the fact that the package is just simply too old, so it uses old features of nodejs that has since been made obsolete.
I am fine with this upgrade. Seems to have no problems.
Proposed merge commit message:
Bump node-sass version to v4.0.0
[email protected] does not build on nodejs 12.14.1 (LTS). The package is
too old, so it uses features of nodejs that has been made obsolete,
resulting in a failed build when the package is building its C++
libraries.
Let's upgrade to [email protected]. A simple run of `npm build` seems to
indicate that there's no changes to our `dist` builds, hence we should
not expect any broken changes.
Can confirm as well, might have been running an older nodejs when I first installed it |
Current node-sass version is too low for it to build on Windows