-
Notifications
You must be signed in to change notification settings - Fork 138
Add tooltip for copy and wrap plugins #2657
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
- Aligned svg image of copy plugin. - Added tooltip to provide better responsiveness.
The "Copied!" success message does not seem to work on the deployed site (Firefox & Chrome) on Windows 10, on my end @Incogdino |
vid.mp4 |
Previously the constants were specified as string literals instead of template literals.
Thanks for noticing this! I have updated the code and should work now! |
Thanks for the changes @Incogdino, I like the new changes for the copy button! The tooltips are quite useful. As an addition, for the wrap button, I wonder if we can indicate the wrap state with css (perhaps light -> dark color scheme for the button when in wrap text mode)? At the moment, when clicking on the wrap text button, there is no visual response on click. We can even have text changes in the tooltip according to whether it is in "wrap mode" or not, though that might be optional if the visual changes are handled well. |
@lhw-1 That is a good suggestion. We can try a colour combination that will not look out of place. For the text changes within the tooltip of text wrap, I'm thinking perhaps a change between "Wrap text" and "Unwrap text" depending on whether the text is wrapped. |
Sounds good to me. Any updates on the PR? @Incogdino |
1. Added visual changes to wrap button on activate and deactivate to denote that the code is wrapped. 2. Updated wrap button tooltip on activate and deactivate.
I have just added changes to the wrap button.
The tooltip text also changes to "unwrap text" to indicate that the next click would unwrap the code |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I like the new dynamic changes - LGTM. Thanks @Incogdino!
@lhw-1 Each PR must have a SEMVER impact label, please remember to label the PR properly. |
Love this, this is awesome! The wrap text tooltip is very useful imo. |
What is the purpose of this pull request?
#2581
Overview of changes:

The current svg of the copy plugin is slightly misaligned and offcentered after clicking once
Chanages made:
Anything you'd like to highlight/discuss:
Testing instructions:
Proposed commit message: (wrap lines at 72 characters)
Add tooltip for copy and wrap plugins
Checklist: ☑️
Reviewer checklist:
Indicate the SEMVER impact of the PR:
At the end of the review, please label the PR with the appropriate label:
r.Major
,r.Minor
,r.Patch
.Breaking change release note preparation (if applicable):