Skip to content

Conversation

LamJiuFong
Copy link
Contributor

What is the purpose of this pull request?

Overview of changes:
Move <script>s to bottom in page.njk

Anything you'd like to highlight/discuss:
Discussed in Issue #2508

Testing instructions:

Proposed commit message: (wrap lines at 72 characters)
Move scripts to bottom in page.njk


Checklist: ☑️

  • Updated the documentation for feature additions and enhancements
  • Added tests for bug fixes or features
  • Linked all related issues
  • No unrelated changes

Reviewer checklist:

Indicate the SEMVER impact of the PR:

  • Major (when you make incompatible API changes)
  • Minor (when you add functionality in a backward compatible manner)
  • Patch (when you make backward compatible bug fixes)

At the end of the review, please label the PR with the appropriate label: r.Major, r.Minor, r.Patch.

Breaking change release note preparation (if applicable):

  • To be included in the release note for any feature that is made obsolete/breaking

Give a brief explanation note about:

  • what was the old feature that was made obsolete
  • any replacement feature (if any), and
  • how the author should modify his website to migrate from the old feature to the replacement feature (if possible).

@LamJiuFong LamJiuFong marked this pull request as ready for review April 20, 2024 06:32
Copy link
Contributor

@yucheng11122017 yucheng11122017 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! looks like panels and modals are still working

Copy link
Contributor

@itsyme itsyme left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks for the effort to investigate and fix the issue!

@yucheng11122017 yucheng11122017 merged commit 4965213 into MarkBind:master Apr 24, 2024
Copy link

@yucheng11122017 Each PR must have a SEMVER impact label, please remember to label the PR properly.

itsyme pushed a commit that referenced this pull request Apr 24, 2024
itsyme pushed a commit that referenced this pull request Apr 24, 2024
@itsyme itsyme added the r.Patch Version resolver: increment by 0.0.1 label Apr 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
r.Patch Version resolver: increment by 0.0.1
Projects
None yet
Development

Successfully merging this pull request may close these issues.

PR2492 causes regression to Modal
3 participants