-
Notifications
You must be signed in to change notification settings - Fork 138
2416 fix gitignore not generated bug #2469
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
2416 fix gitignore not generated bug #2469
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #2469 +/- ##
==========================================
- Coverage 51.22% 51.20% -0.02%
==========================================
Files 124 124
Lines 5281 5283 +2
Branches 1121 1122 +1
==========================================
Hits 2705 2705
- Misses 2290 2291 +1
- Partials 286 287 +1 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the work @LamJiuFong and for the investigation as well!
Generally looks good except for some minor nits.
*.iml |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
unnecessary change
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am not sure how to fix this problem because the changes were made by WebStorm (due to missing EoF line in the original code), I tried using GitHub to remove the last line but nothing happened d62c7ac
Co-authored-by: Chan Yu Cheng <[email protected]>
formatting still got issue ah! that aside, great investigation and thanks for finding a fix so quickly : ) |
….com/LamJiuFong/markbind into 2416-fix-gitignore-not-generated-bug # Conflicts: # packages/core/src/utils/fsUtil.ts
Thanks @kaixin-hc @yucheng11122017 for reviewing! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! thanks!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm ! thank u
@LamJiuFong Can you write a draft PR message that includes the explanation for why this fixes a bug? Thanks! |
@kaixin-hc I have updated the commit message, is that okay? |
What is the purpose of this pull request?
Fixes #2416
Overview of changes:
Rename
.gitignore
togitignore
in template/default and renamegitignore
to.gitignore
when user runmarkbind-cli init
Anything you'd like to highlight/discuss:
I have tested it locally, but I think we can only know if this method actually works until we publish the package on npm, not sure if we are allowed to publish a draft package?
Testing instructions:
Make the changes in this PR and
npm link
an empty folder to the localmarkbind-cli
Ensure that local markbind-cli is linked to local @markbind-core
eg,
In the
packages/cli
directory,Run
npm ls --link
, should see@markbind/[email protected] -> ./packages/core
In the empty folder, run
npx markbind-cli init
, a.gitignore
file will be createdProposed commit message: (wrap lines at 72 characters)
Change .gitignore of the default template to gitignore
The default template has a .gitignore file
.gitignore will be ignored by npm and is not able to be published.
The file will not be created in the users' project.
Let's rename it to gitignore so that it can be published and rename
it back to .gitignore in the users' project.
Checklist: ☑️
Reviewer checklist:
Indicate the SEMVER impact of the PR:
At the end of the review, please label the PR with the appropriate label:
r.Major
,r.Minor
,r.Patch
.Breaking change release note preparation (if applicable):