Skip to content

Conversation

luminousleek
Copy link
Contributor

@luminousleek luminousleek commented Mar 15, 2024

What is the purpose of this pull request?

  • Documentation update
  • Bug fix
  • Feature addition or enhancement
  • Code maintenance
  • DevOps
  • Improve developer experience
  • Others, please explain:

A test in NodeProcessor.test.ts used the expected result for the test input. Let's fix this to actually use the intended test input.

Overview of changes:
Use intended test input instead of expected result.

Anything you'd like to highlight/discuss:
This has been tested with npm run test in the packages/core/ directory.

Testing instructions:

Proposed commit message: (wrap lines at 72 characters)

A test for NodeProcessor had the expected result as the test input.

Let's change it to the intended test input.


Checklist: ☑️

  • Updated the documentation for feature additions and enhancements
  • Added tests for bug fixes or features
  • Linked all related issues
  • No unrelated changes

Reviewer checklist:

Indicate the SEMVER impact of the PR:

  • Major (when you make incompatible API changes)
  • Minor (when you add functionality in a backward compatible manner)
  • Patch (when you make backward compatible bug fixes)

At the end of the review, please label the PR with the appropriate label: r.Major, r.Minor, r.Patch.

Breaking change release note preparation (if applicable):

  • To be included in the release note for any feature that is made obsolete/breaking

Give a brief explanation note about:

  • what was the old feature that was made obsolete
  • any replacement feature (if any), and
  • how the author should modify his website to migrate from the old feature to the replacement feature (if possible).

Copy link

codecov bot commented Mar 15, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 48.93%. Comparing base (eb2d13d) to head (3c9b4d9).

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #2462   +/-   ##
=======================================
  Coverage   48.93%   48.93%           
=======================================
  Files         124      124           
  Lines        5250     5250           
  Branches     1112     1112           
=======================================
  Hits         2569     2569           
  Misses       2376     2376           
  Partials      305      305           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@kaixin-hc kaixin-hc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for catching this!! lgtm

@kaixin-hc kaixin-hc added this to the v5.3.1 milestone Mar 15, 2024
Copy link
Contributor

@yucheng11122017 yucheng11122017 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for the great catch! LGTM

@yucheng11122017 yucheng11122017 merged commit 69c8643 into MarkBind:master Mar 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants