Add AND/OR tag search to card stack component

[Incogdino]

Please confirm that you have searched existing issues in the repo

Yes, I have searched the existing issues

Any related issues?

Related to #2648

What is the area that this feature belongs to?

Reader Usability

Is your feature request related to a problem? Please describe.

Allow users to toggle between AND/OR search for card stack.

Describe the solution you'd like

A button that toggles between AND/OR search for tags

Describe alternatives you've considered

No response

Additional context

No response

[pinion05]

Hi, I'd like to take on this issue. Can I be assigned to it?

[Incogdino]

@pinion05 sure! Ill assign you to this issue. Please make sure to review the dev guide at https://markbind.org/devdocs/devGuide/devGuide.html before starting!

[pinion05]

Hi, I have a question regarding the AND/OR toggle feature.

Do we need to implement AND/OR switching for each individual filter option? Or should there be a single AND/OR toggle that applies to all filter options collectively?

Additionally, if we implement AND/OR switching for each option, I’m planning to add a third click that transitions to a "Required Inclusion" state.

Looking forward to your thoughts!

[lhw-1]

When I initially suggested the feature here, I was actually thinking of a component attribute for the cardstack component's main filtering (e.g. <cardstack searchable blocks="2" logic="AND">). Having a button for toggling this also can work, but my main concern is that this won't see much use since the use case of the card stack will determine if OR or AND is better for the logic.

I don't mind having a button alongside this, though. Maybe the logic attribute can take "AND", "OR", or "BOTH" as values & we can add in the button if "BOTH" is specified? Just throwing ideas out there.

@Incogdino What do you think is a better approach?

[Incogdino]

When I initially suggested the feature here, I was actually thinking of a component attribute for the cardstack component's main filtering (e.g. <cardstack searchable blocks="2" logic="AND">). Having a button for toggling this also can work, but my main concern is that this won't see much use since the use case of the card stack will determine if OR or AND is better for the logic.

I don't mind having a button alongside this, though. Maybe the logic attribute can take "AND", "OR", or "BOTH" as values & we can add in the button if "BOTH" is specified? Just throwing ideas out there.

@Incogdino What do you think is a better approach?

I agree your suggestion is sound. We should go with the logic attribute taking on the options of AND, OR and BOTH and in the last case of BOTH, a toggle for switiching between them would appear in the component.

A concern that I have with this is that readers could be confused with the filter feature of the tags with no indication of whether the filter should be an AND/ OR filter. But I think we should leave this up to the choice of the user creating the site.

[Incogdino]

Do we need to implement AND/OR switching for each individual filter option? Or should there be a single AND/OR toggle that applies to all filter options collectively?

I presume you mean the case of whether this should apply to all card stack components that appear in the site or the indicidual card stack components. If that is the case, then we should make it apply to individual card stack components, preferably stated as an attribute. For example, <cardstack searchable blocks="2" logic="or">

Additionally, if we implement AND/OR switching for each option, I’m planning to add a third click that transitions to a "Required Inclusion" state.

Sorry I'm having troubles understanding what this state means. Could you elaborate more on this @pinion05? Thank you!

[damithc]

There can be use cases where the different readers will want to filter in different ways. Also, the reader may want to know the logic being used. So, I'm in favour of having a visible checkbox. But we can let the author choose if it will be ticked by default. e.g. [ ] AND (with a tooltip giving a longer explanation).

Do we need BOTH? My thinking is, either we use the more restrictive AND search (if ticked), or use the OR by default.

[damithc]

e.g. [ ] AND (with a tooltip giving a longer explanation).

Or [ ] Match all selected ?

[pinion05]

Hi @Incogdino,

I was not saying to create a button that is applied uniformly to all card stack components.

However, there is a part where I thought incorrectly.
I was thinking of creating individual tags or/and like the attached gif.

But I just realized that this is meaningless.
I will improve it by adding a button that applies to the individual CardStack component tag filtering options as suggested.

Sorry for the inconvenience...!