V2 Start and end routine #9
Open
+42
−6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
schultyy
approved these changes
Jan 19, 2024
| if (runningRoutine) { | ||
| runningRoutine.running = false; | ||
| let currentDate = new Date(); | ||
| runningRoutine.end = currentDate.toISOString(); |
There was a problem hiding this comment.
Why are you saving the end date as a string? What speaks against saving it as date time?
|
|
||
| if (!runningRoutine) { | ||
| let currentDate = new Date(); | ||
| let newRoutine = {"start": currentDate.toISOString(), "running": true}; |
There was a problem hiding this comment.
same here as down below - what about storing start as Date instead of String?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements version 2. A user can now start and finish a routine on button click.
This new iteration is not yet saved persistently. I still need to decide how to move on with saving data.