-
Notifications
You must be signed in to change notification settings - Fork 2.5k
HamburgerMenu and Item selection/hover brush improvements #3134
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
punker76
merged 25 commits into
develop
from
feature/HamburgerMenu_UWPCommunityToolkit_CreatorsStyle_pr2975_i2931
Jan 8, 2018
Merged
HamburgerMenu and Item selection/hover brush improvements #3134
punker76
merged 25 commits into
develop
from
feature/HamburgerMenu_UWPCommunityToolkit_CreatorsStyle_pr2975_i2931
Jan 8, 2018
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Update template to keep options visible - Change inner ListBox scrolling (CanContentScroll)
- Add ItemContainerStyle and OptionsItemContainerStyle properties - This makes it easier to change the inner styles for the items (and option items)
- Move template to HamburgerMenuTemplate resource dictionary - Add margins - Vertically stretch the menu items of the hamburger menu
… to subclass ImageSource
HamburgerMenu: HamburgerListBoxItemStyle -> HamburgerMenuItemStyle HamburgerListBoxStyle -> HamburgerMenuListStyle
- `ListItemHelper.ActiveSelectionBackgroundBrush` default `AccentColorBrush` - `ListItemHelper.ActiveSelectionForegroundBrush` default `AccentSelectedColorBrush` - `ListItemHelper.DisabledForegroundBrush` default `GrayNormalBrush` - `ListItemHelper.DisabledSelectedBackgroundBrush` default `GrayBrush7` - `ListItemHelper.DisabledSelectedForegroundBrush` default `AccentSelectedColorBrush` - `ListItemHelper.MouseOverBackgroundBrush` default `AccentColorBrush3` - `ListItemHelper.SelectedBackgroundBrush` default `AccentColorBrush2` - `ListItemHelper.SelectedForegroundBrush` default `AccentSelectedColorBrush`
New brush for hovered selected items: HoverSelectedBackgroundBrush Fix for all: Hovered background if selected background was not set Adjusted brushes for ListBox, ListView, TreeView, ComboBox
…ew ShowSelectionIndicator dependency property
Add new (readonly) ItemFocusVisualStyle dependency property which will be re-created if one of these properties are changed: OpenPaneLength, CompactPaneLength and IsPaneOpen It will be used the default control template HamburgerMenuItemFocusVisualTemplate. This FocusVisualStyle can be override at the HamburgerMenuItem style by setting the FocusVisualStyle property.
Add this new property to change the padding of the inner content in an easy way.
@punker76 how do I expose |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed?
HamburgerMenu
HamburgerMenuItemStyle
HamburgerMenuListStyle
UWPCommunityToolkit
style (update template to keep options visible)HamburgerMenuTemplate
resource dictionaryItemContainerStyle
andOptionsItemContainerStyle
properties. This makes it easier to change the inner styles for the items (and option items)^0
ItemInvoked
event (as an alternative toItemClick
andOptionsItemClick
)SelectionIndicator
which can be enabled with the newShowSelectionIndicator
dependency propertyItemFocusVisualStyle
dependency property which will be re-created if one of these properties are changed:OpenPaneLength
,CompactPaneLength
andIsPaneOpen
.HamburgerMenuItemFocusVisualTemplate
.HamburgerMenuItem
style by setting theFocusVisualStyle
property.ToggleSwitch
ContentPadding
dependency property. Add this new property to change the padding of the inner content in an easy way.ItemHelper
HamburgerMenuItem
,ListBoxItem
,ListViewItem
,TreeViewItem
andComboBoxItem
.ActiveSelectionBackgroundBrush
defaultAccentColorBrush
ActiveSelectionForegroundBrush
defaultAccentSelectedColorBrush
DisabledBackgroundBrush
defaultx:Null
DisabledForegroundBrush
defaultGrayNormalBrush
DisabledSelectedBackgroundBrush
defaultGrayBrush7
DisabledSelectedForegroundBrush
defaultAccentSelectedColorBrush
HoverBackgroundBrush
defaultAccentColorBrush3
HoverSelectedBackgroundBrush
defaultAccentColorBrush
SelectedBackgroundBrush
defaultAccentColorBrush2
SelectedForegroundBrush
defaultAccentSelectedColorBrush
Closes #2931
Closes #2975
Closes #2979