Replacing WindowChrome and related things with reference to ControlzEx #3021
Conversation
… WindowChromeFromControlzEx
|
Don't know why the build fails. |
| using MahApps.Metro.Controls; | ||
| using Microsoft.Windows.Shell; | ||
|
|
||
| public class BorderlessWindowBehavior : WindowChromeBehavior |
There was a problem hiding this comment.
this should be marked as obsolete by using the new WindowChromeBehavior
There was a problem hiding this comment.
Why should this be marked obsolete?
Should we bind things like ResizeBorderThicknessProperty and GlowBrushProperty in InitializeStylizedBehaviors?
There was a problem hiding this comment.
@batzen uuups, didn't see the inheritence ...
| /// Using a DependencyProperty as the backing store for ResizeBorderTickness. This enables animation, styling, binding, etc... | ||
| /// </summary> | ||
| public static readonly DependencyProperty ResizeBorderThicknessProperty = | ||
| DependencyProperty.Register(nameof(ResizeBorderThickness), typeof(Thickness), typeof(MetroWindow), new PropertyMetadata(BorderlessWindowBehavior.GetDefaultResizeBorderThickness())); |
There was a problem hiding this comment.
this should be WindowChromeBehavior instead of the old BorderlessWindowBehavior
There was a problem hiding this comment.
Will use base class name here.
| { | ||
| var behavior = new BorderlessWindowBehavior(); | ||
|
|
||
| Interaction.GetBehaviors(this).Add(behavior); |
There was a problem hiding this comment.
all behaviors must be add here and not at the style
private void InitializeStylizedBehaviors()
{
var collection = new StylizedBehaviorCollection();
collection.Add(new BorderlessWindowBehavior());
collection.Add(new WindowsSettingBehaviour());
collection.Add(new GlowWindowBehavior());
StylizedBehaviors.SetBehaviors(this, collection);
}
without that, the glow and settings behaviors are not working
There was a problem hiding this comment.
Will move behavior creation from the style to code behind.
| <Behaviours:GlowWindowBehavior /> | ||
| </Behaviours:StylizedBehaviorCollection> | ||
| </Setter.Value> | ||
| </Setter> |
There was a problem hiding this comment.
setting the behaviors must be done in InitializeStylizedBehaviors at code behind
|
@Deadpikle Those will need to move repositories as i haven't fixed them. |
System.Windows.Interactivity is now aquired through the dependency to ControlzEx
3 participants
Everything related to WindowChrome and it's associated Behavior is replaced with a reference to ControlzEx.
This also massively increases resize performance of the window.