Skip to content

Use owning window to detect theme for dialogs if available #2840

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 5, 2017
Merged

Use owning window to detect theme for dialogs if available #2840

merged 1 commit into from
Feb 5, 2017

Conversation

thoemmi
Copy link
Collaborator

@thoemmi thoemmi commented Feb 3, 2017

If a dialog is shown in a window other than the MainWindow, use OwningWindow if available to detect the theme.

This fixes #2835

@thoemmi thoemmi requested a review from punker76 February 3, 2017 21:48
@thoemmi thoemmi added this to the 1.5.0 milestone Feb 3, 2017
punker76
punker76 approved these changes Feb 5, 2017
View reviewed changes
Copy link
Member

@punker76 punker76 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@punker76 punker76 merged commit c7733dd into develop Feb 5, 2017
@thoemmi thoemmi deleted the Issue2835-multithreading branch February 5, 2017 17:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@punker76 punker76 punker76 approved these changes

Assignees

@thoemmi thoemmi

@punker76 punker76

Labels

None yet

Milestone

1.5.0

Development

Successfully merging this pull request may close these issues.

ShowMessageAnsync() causes exception

2 participants

@thoemmi @punker76