Fix for FlipView : Navigation's button visibility and Transition update #2750
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…l's orientation changes.
punker76
requested changes
Nov 19, 2016
| return CoerceSelectedIndexProperty(d, value); | ||
| } | ||
| }); | ||
| } |
There was a problem hiding this comment.
Can you add more documentation what this code does?
| Minimum="1" | ||
| Maximum="{Binding Path=Items.Count, Mode=OneWay}" | ||
| Value="{Binding Path=SelectedIndex, Mode=TwoWay, Converter={vc:Int32IndexToNumberConverter}}"/> | ||
| <TextBlock VerticalAlignment="Center" Margin="8 0 0 0"> |
There was a problem hiding this comment.
Why not starting from 0? Then you don't need the Int32IndexToNumberConverter.
There was a problem hiding this comment.
You're absolutely right.
It's just that users tend to prefer message 'Viewing item 1 on 2' than 'Viewing item 0 on 1'.
Hence the shift of 1.
|
Here you are, i added a detail explanation of the coercion trick. |
punker76
approved these changes
Nov 19, 2016
|
@jumulr why closed? |
|
Mistake, sorry. Is that ok ? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refresh navigation buttons' visibility when control's orientation changes.
Handle navigation buttons' visibility when toggling their display.
Apply transition when SelectedIndex changes.