Revert #2575 and fix problem in a way that doesn't break the SplitBut… #2616
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Argh. This fix still causes a really, really strange issue in my project where I have to mouse off and back on the window in order to make anything in the window respond. I'm working on it... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
...ton's popup menu.
What changed?
#2575 closed the SplitButton's popup if you clicked the scroll bar. Totally my fault and lack of testing there. I apologize.
This pull request fixes #2574 (popup stays open if you Alt+Tab) in a different way that also keeps the scroll bar mouse down working. Things seem to work as expected again.