Interact with DialogController from Background Thread #2556
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This will fix the issue where you cannot use the DialogCoordinator in following scenarios: - during async/await - within Task.Run(...) - within Task.Factory.Run(...) - any other Background strategies.
Conflicts: samples/MetroDemo/MainWindowViewModel.cs
|
@punker76 is there any bug in this PR, because of the Bug tag? |
|
@xxMUROxx I marked it with the Bug tag cause it's a bug if we don't' t use the Dispatcher ;-) |
|
@punker76 Ok, understood 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed?
It is possible to show and hide dialogs from any thread
Fixes issue with threads as indicated in Hide all visible Metro Dialogs before showing another one