Fixes the HasDecimals property, broken before on commit bd6aa38e. #2404
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
feinstein
changed the title
punker76
added a commit
that referenced
this pull request
Mar 8, 2016
Fixes the HasDecimals property, broken before on commit bd6aa38.
|
@feinstein Please make the next PR on dev branch, thx. |
|
@punker76 OK! Sorry, I thought since this was fix, and not a new feature to be developed, it should go straight to master. |
|
@feinstein you're normaly right, but I'm focused on finishing 1.3.0 |
|
Ok, got it! @punker76 I have been thinking on adding a feature to block the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed?
Fixed the
HasDecimalsproperty. It was broken on commit bd6aa38 which made the property stop working and decimals like ',' '.' were available whenHasDecimals = false.closes issue #2403.