Skip to content

ToggleSwitch improvements and fixes #1945

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 13 commits into from
Jun 1, 2015
Merged

ToggleSwitch improvements and fixes #1945

merged 13 commits into from
Jun 1, 2015

Conversation

punker76
Copy link
Member

  • new dependency property ToggleSwitchButtonStyle
  • BorderThickness and BorderBrush for toggle button style now customizable
  • new font keys
    • ToggleSwitchFontFamily and ToggleSwitchHeaderFontFamily
    • ToggleSwitchFontSizeand ToggleSwitchHeaderFontSize
  • new dependency properties to change brushes
    • OnSwitchBrush and OffSwitchBrush
    • ThumbIndicatorBrush and ThumbIndicatorDisabledBrush
  • new dependency property ThumbIndicatorWidth
  • Validation.ErrorTemplate support
  • Keyboard focus if the ToggleSwitch itself or the toggle button was clicked
  • Fixed on/off label binding issue MVVM Binding OnLabel isn't working #1867
  • introduce commands for mvvm usage
    • CheckChangedCommand, CheckedCommand and UnCheckedCommand
    • CheckChangedCommandParameter, CheckedCommandParameter and UnCheckedCommandParameter

Closes #1917 ToggleSwitch validation shows red border but doesn't show error text
Closes #1867 MVVM Binding OnLabel isn't working
Closes #1464 Add "Command" property for ToggleSwitch control

@QuantumDeveloper
Copy link
Contributor

👍

@punker76 punker76 mentioned this pull request May 30, 2015
Closed
@punker76 punker76 added this to the 1.2.0 milestone Jun 1, 2015
punker76 added a commit that referenced this pull request Jun 1, 2015
@punker76
Merge pull request #1945 from MahApps/ToggleSwitch-improvements
c60f060 
ToggleSwitch improvements and fixes
@punker76 punker76 merged commit c60f060 into master Jun 1, 2015
@punker76 punker76 deleted the ToggleSwitch-improvements branch June 16, 2015 22:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Milestone
1.2.0
Development

Successfully merging this pull request may close these issues.
2 participants
@punker76 @QuantumDeveloper