Fix SplitButton SelectedIndex and SelectedItem #1798
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Using 0 as the default selected index would cause SplitButton to always set SelectedItem to the first element in the ItemsSource. When SelectedItem is bound to a property in the ViewModel the value set in the ViewModel is ignored/replaced.
Using two-way binding by default for SelectedItem and SelectedIndex matches the behaviour of other controls like ComboBox
|
👍 |
punker76
added a commit
that referenced
this pull request
Feb 13, 2015
Fix SplitButton SelectedIndex and SelectedItem
|
@jiggak thx |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These fixes make SplitButton work a little bit better as a drop in replacement for ComboBox