lazy artifacts, matpower, default types #13
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sshin23
reviewed
Aug 13, 2025
|
|
||
| [deps] | ||
| Artifacts = "56f22d72-fd6d-98f1-02f0-08ddc0907c33" | ||
| LazyArtifacts = "4af54fe1-eca0-43a8-85a7-787d91b784e3" |
Member
There was a problem hiding this comment.
Do we still need LazyArtifacts? This package seems to be archived
sshin23
reviewed
Aug 13, 2025
benchmark/runbenchmarks.jl
Outdated
| using ExaPowerIO, BenchmarkTools, PowerModels, PGLib, Profile, PProf, Logging, JLD2 | ||
| using BenchmarkTools, PowerModels, PGLib, Profile, PProf, Logging, JLD2, Pkg | ||
|
|
||
| Pkg.activate("..") |
Member
There was a problem hiding this comment.
If we're gonna activate .., there's no point in having a separate Project.toml. You can add ExaPowerIO in Project.toml without specifying the compat. Or, you can use the path [source] entrie within https://pkgdocs.julialang.org/v1/toml-files/#The-[sources]-section
sshin23
approved these changes
Aug 13, 2025
Member
sshin23
left a comment
sshin23
left a comment
There was a problem hiding this comment.
Good to merge once the comments are addressed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this pr addresses issues:
#12
#11
#10
#9