remove solr555 from search engine code #1855
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove one layer of abstraction by letting Solr9PySolrSearchEngine inherit from SearchEngineBase directly
|
I'm holding off on merging this because I have one final experiment that I want to run to evaluate solr 5 vs solr 9, we can merge when that is done |
|
Also I had to make some changes in the solr 555 code so there'll be conflicts now that need to be addressed, sorry about that :S |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue(s)
maybe related (?): #1741
Description
Solr9PySolrSearchEngineinherit fromSearchEngineBasedirectly.SearchEngineBasetoutils.search.backendsDeployment steps: