Cast width and height variables to uint32_t #223
Merged
+4
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LukasBanana
reviewed
Aug 25, 2025
| @@ -98,7 +98,7 @@ static void XDGTopLevelHandleConfigureCallback( | |||
| LinuxWindowWayland::State& state = window->GetState(); | |||
|
|
|||
| if (width != 0 && height != 0 && (width != state.size.width || height != state.size.height)) | |||
There was a problem hiding this comment.
You're still comparing signed with unsigned integers here. Maybe it's more elegant to construct the new Extent2D size before the if-statement and then just compare newSize != state.size.
There was a problem hiding this comment.
Yeah, you're right :)
added 2 commits
August 26, 2025 19:34
LukasBanana
approved these changes
Aug 26, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes a
clangerror: