Skip to content

Add validation and comments to OpenBehavior entity. #1078

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
jbogard merged 3 commits into from
Mar 23, 2025
Merged

Add validation and comments to OpenBehavior entity. #1078

jbogard merged 3 commits into from
Mar 23, 2025

Conversation

@Emopusta
Copy link
Contributor

@Emopusta Emopusta commented Oct 1, 2024

  • Added a validation method ValidatePipelineBehaviorType to ensure the provided type implements the IPipelineBehavior<,> interface. An InvalidOperationException is thrown if the type does not implement the required interface. Also, this method ensures that a valid openBehaviorType is provided, throwing an ArgumentNullException if the type is null.

  • Added comprehensive XML comments for the class, properties, and methods to improve code readability and maintainability.

@Emopusta
Copy link
Contributor Author

Emopusta commented Oct 1, 2024

Waiting for #1072 to proceed.

@github-actions
Copy link

github-actions bot commented Oct 30, 2024

This PR is stale because it has been open 28 days with no activity. Remove stale label or comment or this will be closed in 14 days.

@github-actions github-actions bot added the Stale label Oct 30, 2024
@Emopusta
Copy link
Contributor Author

Emopusta commented Oct 30, 2024

This PR is not stale. Waiting for #1072 for CI / build (pull_request) github action update fix. After that merge this PR will be ready for merge. @jbogard

@Emopusta
Copy link
Contributor Author

Emopusta commented Oct 30, 2024

Thank you for your response. This PR is all set and waiting for your review. @jbogard

@github-actions github-actions bot removed the Stale label Oct 31, 2024
@github-actions
Copy link

github-actions bot commented Nov 28, 2024

This PR is stale because it has been open 28 days with no activity. Remove stale label or comment or this will be closed in 14 days.

@github-actions github-actions bot added the Stale label Nov 28, 2024
@Emopusta
Copy link
Contributor Author

Emopusta commented Nov 28, 2024

This PR is not stale. Waiting for review. @jbogard

@github-actions github-actions bot removed the Stale label Nov 29, 2024
@github-actions
Copy link

github-actions bot commented Dec 28, 2024

This PR is stale because it has been open 28 days with no activity. Remove stale label or comment or this will be closed in 14 days.

@github-actions github-actions bot added the Stale label Dec 28, 2024
@Emopusta
Copy link
Contributor Author

Emopusta commented Dec 28, 2024

This PR is not stale. Waiting for review. @jbogard

@github-actions github-actions bot removed the Stale label Dec 29, 2024
@github-actions
Copy link

github-actions bot commented Jan 27, 2025

This PR is stale because it has been open 28 days with no activity. Remove stale label or comment or this will be closed in 14 days.

@github-actions github-actions bot added the Stale label Jan 27, 2025
@Emopusta
Copy link
Contributor Author

Emopusta commented Jan 27, 2025

This PR is not stale. Waiting for review. @jbogard @zachpainter77

@github-actions github-actions bot removed the Stale label Jan 28, 2025
@Emopusta
Copy link
Contributor Author

Emopusta commented Feb 3, 2025

@jbogard

@github-actions
Copy link

github-actions bot commented Mar 4, 2025

This PR is stale because it has been open 28 days with no activity. Remove stale label or comment or this will be closed in 14 days.

@github-actions github-actions bot added the Stale label Mar 4, 2025
@Emopusta
Copy link
Contributor Author

Emopusta commented Mar 4, 2025

This PR is not stale. Waiting for review. @jbogard

@github-actions github-actions bot removed the Stale label Mar 5, 2025
@jbogard jbogard merged commit e839444 into LuckyPennySoftware:master Mar 23, 2025
4 checks passed
This was referenced Jul 21, 2025
Closed
Closed
This was referenced Nov 24, 2025
Closed
Closed
Closed
Closed
Open
Open
Closed
This was referenced Dec 2, 2025
Closed
Closed
Closed
Closed
Open
Open
Open
Open
Open
Open
Open
Open
Closed
Open
This was referenced Dec 10, 2025
Open
Open
Open
Open
Closed
Open
Closed
Open
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jbogard jbogard jbogard approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@Emopusta @jbogard