Skip to content

Conversation

Angelinsky7
Copy link
Contributor

@Angelinsky7
Copy link
Contributor Author

@lbargaoanu i think i corrected almost everything. (apart from the override parameter that i really would like to talk about)

@Angelinsky7 Angelinsky7 marked this pull request as ready for review August 4, 2023 11:39
base.Seed(context);
}
}
protected override MapperConfiguration CreateConfiguration() => new(c => c.CreateProjection<Entity, Dto>().ForCtorParam("Name", o => o.ExplicitExpansion(false)));
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should use mapping inheritance, the same as the test below.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@lbargaoanu i added a new test for constructor mapping with inheritance (sorry for the long delay i needed to change my computer)

@lbargaoanu lbargaoanu marked this pull request as draft August 18, 2023 07:56
@lbargaoanu lbargaoanu marked this pull request as ready for review August 21, 2023 12:44
@lbargaoanu lbargaoanu force-pushed the disable_explicit_expansion branch from 41d0619 to 0b9fbce Compare August 21, 2023 13:13
@Angelinsky7
Copy link
Contributor Author

if you do that, you loose all the advantage of doing this pr !
i don't understand why you would want to make all user need to change all their code by needing to pass a value (it breaks compatibility)

@lbargaoanu lbargaoanu merged commit 2d8af82 into LuckyPennySoftware:basic_include Aug 21, 2023
@lbargaoanu
Copy link
Contributor

lbargaoanu commented Aug 21, 2023

Obviously it doesn't, all the existing tests pass.

@lbargaoanu
Copy link
Contributor

Well, that's what's needed here. The ForAllMembers stuff is ForAllOtherMembers in disguise, nothing that makes sense for AM. If you want that, just add an if as I've already said.

@LuckyPennySoftware LuckyPennySoftware locked and limited conversation to collaborators Aug 22, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants