-
Notifications
You must be signed in to change notification settings - Fork 2.4k
ProjectTo runtime polymorphic mapping with Include/IncludeBase #4280
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bca179f
to
6de86f6
Compare
Try the MyGet build. |
b21e7ca
to
41162d4
Compare
7d7a2fc
to
213a903
Compare
Support projecting to an abstract type when there are included maps and also including an abstract map, presumably for configuration reuse
300ef95
to
0db9ff6
Compare
8da868e
to
af2d7a2
Compare
af2d7a2
to
b09f9b1
Compare
4a5366d
to
4c8207c
Compare
any eta when this will be merged? is there a blocker remaining that needs resolving? |
@jbogard AM 13? |
850b40f
to
99be09f
Compare
LGTM and released! |
Let's do this, guys |
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@JanEggers As far as I can tell, it's not much to it. And half is just moving code around. The tests you added seem to work, modulo the expression checking. So if you can add those to this PR, that would be it.