thickness calculator #25
Conversation
…Loop3D/plugin_map2loop into processing/thickness_calculator
noellehmcheng
changed the base branch from
processing/thickness_calculator
to
processing/processing_tools
|
|
This branch was created from processing/thickness_calculator which does not include updated code from processing/procecssing_tools, which makes this pull request show many unrelated code diff. |
rabii-chaarani
left a comment
rabii-chaarani
left a comment
There was a problem hiding this comment.
You can merge after resolving the conflicts and making the requested changes
|
|
||
| fields = QgsFields() | ||
| fields.append(QgsField("ID", QVariant.String)) | ||
| fields.append(QgsField("X", QVariant.Double)) |
There was a problem hiding this comment.
We should use QVariant for the moment, as QMetaType don't work for older versions
| self.addParameter( | ||
| QgsProcessingParameterEnum( | ||
| 'THICKNESS_ORIENTATION_TYPE', | ||
| 'Thickness Orientation Type', |
There was a problem hiding this comment.
It should be "Orientation Type". Just FYI," Thickness orientation type" doesn't exist in geology.
There was a problem hiding this comment.
The user should be able to choose between having a manual bounding box or using the extent of any polygon layer they want. So, you can add another parameter of the layer they want to use for the bounding box
| geology_layer = self.parameterAsVectorLayer(parameters, self.INPUT_GEOLOGY, context) | ||
| extent = geology_layer.extent() | ||
| bounding_box = { | ||
| 'minx': extent.xMinimum(), | ||
| 'miny': extent.yMinimum(), |
There was a problem hiding this comment.
See comment above for the removed bounding box parameter
No description provided.