Add support for round icons. #1
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Lineage is based on keeping aosp look with awesome features, so i propose, we should enable round icons to keep up with the aosp looks.
Author
|
From 657c329 Mon Sep 17 00:00:00 2001 Lineage is based on keeping aosp look with awesome features, so i propose, we should enable round icons to keep up with the aosp looks.core/res/res/values/config.xml | 2 +- diff --git a/core/res/res/values/config.xml b/core/res/res/values/config.xml
|
Contributor
|
Hi there; This is an automated reply, to let you know LineageOS doesn't merge pull You can submit your change requests through our public review system, That review system is an installation of Google's Gerrit code review. Thanks! |
0xf104a
pushed a commit
to MilkyWayOS/android_frameworks_base
that referenced
this pull request
Feb 24, 2024
There are two existing cases where apps that share a sharedUserId potentially end up in separate SELinux domains. 1. An app installed in /system/priv-app runs in the priv_app domain. An app installed on the /data partition which shares a sharedUserId with that priv_app would run in the untrusted_app domain (e.g. GTS b/72235911). This issue has existed since Android N. 2. The untrusted_app domain may now deprecate permissions based on targetSdkVersion, so apps with sharedUserId may have different permissions based on which targetSdkVersion they use. This issue has existed since Android O, but is particularly problematic for feature "Deprecate world accessible app data" which puts every app targeting P+ into its own selinux domain. This change fixes LineageOS#1 and adds a temporary workaround to prevent LineageOS#2. Test: cts-tradefed run cts -m CtsSelinuxTargetSdkCurrentTestCases Test: cts-tradefed run cts -m CtsSelinuxTargetSdk27TestCases Test: cts-tradefed run cts -m CtsSelinuxTargetSdk25TestCases Bug: 72290969 Change-Id: I211de05ad6f10b69e3e082cfe977f2dd43d90549
0xf104a
pushed a commit
to MilkyWayOS/android_frameworks_base
that referenced
this pull request
Feb 24, 2024
There are two existing cases where apps that share a sharedUserId potentially end up in separate SELinux domains. 1. An app installed in /system/priv-app runs in the priv_app domain. An app installed on the /data partition which shares a sharedUserId with that priv_app would run in the untrusted_app domain (e.g. GTS b/72235911). This issue has existed since Android N. 2. The untrusted_app domain may now deprecate permissions based on targetSdkVersion, so apps with sharedUserId may have different permissions based on which targetSdkVersion they use. This issue has existed since Android O, but is particularly problematic for feature "Deprecate world accessible app data" which puts every app targeting P+ into its own selinux domain. This change fixes LineageOS#1 and adds a temporary workaround to prevent LineageOS#2. Updated version considers both SharedUserSetting.isPrivileged() and pkg.isPrivileged() for the case where the app has a shared User. Test: cts-tradefed run cts -m CtsSelinuxTargetSdkCurrentTestCases Test: cts-tradefed run cts -m CtsSelinuxTargetSdk27TestCases Test: cts-tradefed run cts -m CtsSelinuxTargetSdk25TestCases Test: confirm via packages.list that apps end up in the same selinux domain before and after this patch. Bug: 72290969 Change-Id: I974bea88004622b70633fdeb54a1372fd04c6eff
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Lineage is based on keeping aosp look with awesome features, so i propose, we should enable round icons to keep up with the aosp looks.