Skip to content

tests(execution): runtime decoder #255

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Oct 23, 2023
Merged

tests(execution): runtime decoder #255

merged 5 commits into from
Oct 23, 2023

Conversation

nicksinch
Copy link
Contributor

Detailed description:

  • Adds unit tests for the runtime decoder

Which issue(s) this PR fixes:
Part of #215

Special notes for your reviewer:

Checklist

  • Documentation added
  • Tests updated

@nicksinch nicksinch force-pushed the unit-tests-rt_decoder branch 4 times, most recently from 639363e to 743e22d Compare October 23, 2023 07:12
@nicksinch nicksinch force-pushed the unit-tests-rt_decoder branch from 743e22d to fd724f7 Compare October 23, 2023 08:13
radkomih
radkomih previously approved these changes Oct 23, 2023
@failfmi
Copy link
Collaborator

failfmi commented Oct 23, 2023

There are two missing test cases with DecodeUncheckedExtrinsic - invalid extrinsic version and invalid length prefix

failfmi
failfmi previously approved these changes Oct 23, 2023
@failfmi failfmi self-requested a review October 23, 2023 09:07
@nicksinch nicksinch dismissed stale reviews from failfmi and radkomih via ad2b16c October 23, 2023 10:56
@nicksinch nicksinch force-pushed the unit-tests-rt_decoder branch from fd724f7 to ad2b16c Compare October 23, 2023 10:56
@radkomih radkomih merged commit e02ac12 into develop Oct 23, 2023
@radkomih radkomih deleted the unit-tests-rt_decoder branch October 23, 2023 11:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants