Skip to content

test(api): transaction payment #234

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 12, 2023
Merged

test(api): transaction payment #234

merged 1 commit into from
Oct 12, 2023

Conversation

failfmi
Copy link
Collaborator

@failfmi failfmi commented Oct 11, 2023

Detailed description:

  • move DefaultTip to constants
  • refactor uxt IsSigned to return bool instead of goscale.Bool
  • test(api): tx payment

Which issue(s) this PR fixes:
Part of #189

Special notes for your reviewer:

Checklist

  • Documentation added
  • Tests updated

@failfmi failfmi added this to the Phase 2 - M1 - Modularisation milestone Oct 11, 2023
@failfmi failfmi requested a review from radkomih October 11, 2023 13:36
@failfmi failfmi self-assigned this Oct 11, 2023
@failfmi failfmi merged commit fafc91c into develop Oct 12, 2023
@failfmi failfmi deleted the test/api/transaction-payment branch October 12, 2023 05:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@radkomih radkomih radkomih approved these changes

Assignees

@failfmi failfmi

Labels
None yet
Projects
Gosemble - Polkadot Runtimes
Status: ✅ Done
Milestone
Phase 2 - M1 - Modularisation
Development

Successfully merging this pull request may close these issues.
2 participants
@failfmi @radkomih