Skip to content

refactor(unit-tests): frame modules and mocks #223

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Oct 10, 2023
Merged

Conversation

failfmi
Copy link
Collaborator

@failfmi failfmi commented Oct 6, 2023

Detailed description:

  • refactor mocks to use .Get instead of directly accessing slice elements
  • test public funcs instead of private where logic is straightforward
  • add missing tests in aura
  • add missing tests in grandpa
  • add missing tests in system

Which issue(s) this PR fixes:
Fixes #

Special notes for your reviewer:

Checklist

  • Documentation added
  • Tests updated

@failfmi failfmi requested a review from radkomih October 6, 2023 13:38
@failfmi failfmi self-assigned this Oct 6, 2023
@failfmi failfmi changed the title refactor(unit-tests): system, support, mocks refactor(unit-tests): system, timestamp, support, mocks Oct 6, 2023
@failfmi failfmi changed the title refactor(unit-tests): system, timestamp, support, mocks refactor(unit-tests): modules and mocks Oct 6, 2023
@failfmi failfmi changed the title refactor(unit-tests): modules and mocks refactor(unit-tests): frame modules and mocks Oct 6, 2023
@failfmi failfmi added this to the Phase 2 - M1 - Modularisation milestone Oct 6, 2023
@failfmi failfmi merged commit 1284102 into develop Oct 10, 2023
@failfmi failfmi deleted the refactor/unit-tests branch October 10, 2023 06:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants