-
Notifications
You must be signed in to change notification settings - Fork 3.6k
docs: update for Fabric #21125
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: update for Fabric #21125
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR improves the documentation for PyTorch Lightning Fabric by adding comprehensive docstring enhancements and examples throughout the main Fabric class. The changes focus on making the API more user-friendly and accessible for developers.
- Enhanced docstrings with detailed parameter descriptions, default values, and return type information
- Added practical code examples for all major methods showing common usage patterns
- Improved error handling documentation with specific exception types and conditions
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Co-authored-by: Copilot <[email protected]>
⚡ Required checks status: All passing 🟢Groups summary🟢 pytorch_lightning: Tests workflow
These checks are required after the changes to 🟢 pytorch_lightning: Azure GPU
These checks are required after the changes to 🟢 pytorch_lightning: Benchmarks
These checks are required after the changes to 🟢 fabric: Docs
These checks are required after the changes to 🟢 lightning_fabric: CPU workflow
These checks are required after the changes to 🟢 lightning_fabric: Azure GPU
These checks are required after the changes to 🟢 mypy
These checks are required after the changes to 🟢 install
These checks are required after the changes to Thank you for your contribution! 💜
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #21125 +/- ##
=======================================
Coverage 87% 87%
=======================================
Files 269 269
Lines 23560 23560
=======================================
Hits 20546 20546
Misses 3014 3014 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great
What does this PR do?
improve the user experience reading docs about Fabric
Before submitting
PR review
Anyone in the community is welcome to review the PR.
Before you start reviewing, make sure you have read the review guidelines. In short, see the following bullet-list:
Reviewer checklist
📚 Documentation preview 📚: https://pytorch-lightning--21125.org.readthedocs.build/en/21125/
cc @justusschock @lantiga