fix: don't ignore unresizable windows during DND #402
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This partially reverts d960eed. That commit added a check to ensure that unresizable and skip_taskbar windows are ignored during drag and drop operations to fix #387, which was about the tile preview being shown for windows that can't be tiled. This doesn't work. "real" maximized windows don't allow resizing. So if a window was maximized at the start of the DND operation we skipped the whole tiling code. So let's only ignore skip_taskbar windows. This means actually unresizable windows may trigger the tile preview (#387), but that is better than skipping the whole DND code for maximized windows, which is more common than a user trying to tile an unresizable window. We need to fix the original issue in a different way. Fixes #400
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This partially reverts d960eed. That commit added a check to ensure that
unresizable and skip_taskbar windows are ignored during drag and drop
operations to fix #387, which was about the tile preview being shown
for windows that can't be tiled.
This doesn't work. "real" maximized windows don't allow resizing. So if
a window was maximized at the start of the DND operation we skipped the
whole tiling code. So let's only ignore skip_taskbar windows. This means
actually unresizable windows may trigger the tile preview (#387), but
that is better than skipping the whole DND code for maximized windows,
which is more common than a user trying to tile an unresizable window.
We need to fix the original issue in a different way.
Fixes #400