Skip to content

Conversation

ofreyssinet-ledger
Copy link
Contributor

πŸ“ Description

  • Adding "h1Inter" text variant Figma for reference
  • Fix a layout issue on the web native-ui storybook

❓ Context

  • Impacted projects: llm
  • Linked resource(s): Figma

βœ… Checklist

  • Test coverage
  • Atomic delivery
  • No breaking changes

πŸ“Έ Demo

Screenshot 2022-08-09 at 17 26 33

πŸš€ Expectations to reach

Please make sure you follow these Important Steps.

Pull Requests must pass the CI and be internally validated in order to be merged.

@vercel
Copy link

vercel bot commented Aug 9, 2022

The latest updates on your projects. Learn more about Vercel for Git β†—οΈŽ

Name Status Preview Updated
live-common-tools βœ… Ready (Inspect) Visit Preview Aug 12, 2022 at 8:51AM (UTC)
native-ui-storybook βœ… Ready (Inspect) Visit Preview Aug 12, 2022 at 8:51AM (UTC)
2 Ignored Deployments
Name Status Preview Updated
ledger-live-github-bot ⬜️ Ignored (Inspect) Aug 12, 2022 at 8:51AM (UTC)
react-ui-storybook ⬜️ Ignored (Inspect) Aug 12, 2022 at 8:51AM (UTC)

@changeset-bot
Copy link

changeset-bot bot commented Aug 9, 2022

πŸ¦‹ Changeset detected

Latest commit: 9ab3527

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
@ledgerhq/native-ui Patch
live-mobile Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions bot added the ui Has changes in the design system library label Aug 9, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Aug 9, 2022

@ofreyssinet-ledger

Screenshots: βœ…

There are no changes in the screenshots for this PR. If this is expected, you are good to go.

@codecov
Copy link

codecov bot commented Aug 10, 2022

Codecov Report

Merging #891 (06499b2) into develop (dd83a42) will not change coverage.
The diff coverage is n/a.

❗ Current head 06499b2 differs from pull request most recent head 9ab3527. Consider uploading reports for the commit 9ab3527 to get more accurate results

@@           Coverage Diff            @@
##           develop     #891   +/-   ##
========================================
  Coverage    47.92%   47.92%           
========================================
  Files          620      620           
  Lines        27870    27870           
  Branches      7177     7177           
========================================
  Hits         13358    13358           
  Misses       13393    13393           
  Partials      1119     1119           
Flag Coverage Ξ”
test 47.92% <ΓΈ> (ΓΈ)

Flags with carried forward coverage won't be shown. Click here to find out more.

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ui Has changes in the design system library
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants