Skip to content

Conversation

cgrellard-ledger
Copy link
Contributor

✅ Checklist

  • npx changeset was attached.
  • Covered by automatic tests.
  • Impact of the changes:
    • ...

📝 Description

The modular drawer now falls back on the default configuration if a wrong one has been sent instead of not displaying anything
Rename the asset left element from priceVariation to marketTrend to be consistent with the right element

❓ Context

  • JIRA or GitHub link:

🧐 Checklist for the PR Reviewers

  • The code aligns with the requirements described in the linked JIRA or GitHub issue.
  • The PR description clearly documents the changes made and explains any technical trade-offs or design decisions.
  • There are no undocumented trade-offs, technical debt, or maintainability issues.
  • The PR has been tested thoroughly, and any potential edge cases have been considered and handled.
  • Any new dependencies have been justified and documented.
  • Performance considerations have been taken into account. (changes have been profiled or benchmarked if necessary)

@cgrellard-ledger cgrellard-ledger requested review from a team as code owners September 8, 2025 13:53
@live-github-bot live-github-bot bot added desktop Has changes in LLD common Has changes in live-common labels Sep 8, 2025
Copy link

vercel bot commented Sep 8, 2025

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Preview Comments Updated (UTC)
web-tools Error Error Sep 8, 2025 3:25pm
3 Skipped Deployments
Project Deployment Preview Comments Updated (UTC)
ledger-live-github-bot Ignored Ignored Preview Sep 8, 2025 3:25pm
native-ui-storybook Ignored Ignored Preview Sep 8, 2025 3:25pm
react-ui-storybook Ignored Ignored Preview Sep 8, 2025 3:25pm

Copy link

sonarqubecloud bot commented Sep 8, 2025

Quality Gate Failed Quality Gate failed

Failed conditions
0.0% Coverage on New Code (required ≥ 80%)

See analysis details on SonarQube Cloud

@cgrellard-ledger cgrellard-ledger merged commit a480c4e into develop Sep 8, 2025
67 of 70 checks passed
@cgrellard-ledger cgrellard-ledger deleted the feat/lld-mad-modularization-fallback branch September 8, 2025 18:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
common Has changes in live-common desktop Has changes in LLD
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants