Skip to content

Conversation

Wozacosta
Copy link
Contributor

@Wozacosta Wozacosta commented Aug 20, 2025

βœ… Checklist

  • npx changeset was attached.
  • Covered by automatic tests.
  • Impact of the changes:
    • ...

πŸ“ Description

The immutable checks would sometime crash the app as such:

Shottr 2025-08-19 14 27 56

Next step is: try to avoid mutating bitcoinresources (PR is here).

❓ Context

  • JIRA or GitHub link:

🧐 Checklist for the PR Reviewers

  • The code aligns with the requirements described in the linked JIRA or GitHub issue.
  • The PR description clearly documents the changes made and explains any technical trade-offs or design decisions.
  • There are no undocumented trade-offs, technical debt, or maintainability issues.
  • The PR has been tested thoroughly, and any potential edge cases have been considered and handled.
  • Any new dependencies have been justified and documented.
  • Performance considerations have been taken into account. (changes have been profiled or benchmarked if necessary)

@Wozacosta Wozacosta requested a review from a team as a code owner August 20, 2025 09:32
Copy link

vercel bot commented Aug 20, 2025

The latest updates on your projects. Learn more about Vercel for GitHub.

4 Skipped Deployments
Project Deployment Preview Comments Updated (UTC)
ledger-live-github-bot Ignored Ignored Preview Aug 20, 2025 9:43am
native-ui-storybook Ignored Ignored Preview Aug 20, 2025 9:43am
react-ui-storybook Ignored Ignored Preview Aug 20, 2025 9:43am
web-tools Ignored Ignored Preview Aug 20, 2025 9:43am

@live-github-bot live-github-bot bot added the desktop Has changes in LLD label Aug 20, 2025
@Wozacosta Wozacosta merged commit c0bc474 into develop Aug 20, 2025
51 of 55 checks passed
@Wozacosta Wozacosta deleted the chore/rtk-disable-immutable-check-middleware branch August 20, 2025 10:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
desktop Has changes in LLD
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants