Smartling on-demand translation delivery from release #11350
Conversation
![smartling-github-connector[bot]](https://avatars.githubusercontent.com/in/864682?s=60&v=4){kind=small}
…d to ru-RU locale
…d to ar-AE locale
…d to ko-KR locale
…d to tr-TR locale
…d to fr-FR locale
…d to th-TH locale
…d to pt-BR locale
…d to ja-JP locale
…d to de-DE locale
…d to zh-CN locale
…d to es-ES locale
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 4 Skipped Deployments
|
live-github-bot
bot
added
desktop
There was a problem hiding this comment.
Pull Request Overview
This PR delivers automated translation updates from Smartling to multiple localization files across both mobile and desktop Ledger Live applications. The changes include standardizing error messages, adding new staking terminology, and improving account management text consistency across languages.
- Adding new device reconnection error handling translations
- Implementing consistent "netApy" (Net APY) translations for staking features
- Streamlining account count display text by removing "(detected)" qualifier
Reviewed Changes
Copilot reviewed 22 out of 22 changed files in this pull request and generated 4 comments.
| File | Description |
|---|---|
| Mobile locale files (11 files) | Added ReconnectionFailedError translations, netApy staking terms, and simplified accountCount text |
| Desktop locale files (11 files) | Added comprehensive device error handling, netApy staking terms, mock account generation features, and custom lock screen testing |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
| @@ -4271,7 +4275,7 @@ | |||
| "addAccounts" : { | |||
| "addNew" : "Добавить новый", | |||
| "seeAllAccounts" : "Показать все", | |||
| "addNewOrExisting" : "Добавить ещё один счёт", | |||
| "addNewOrExisting" : "Добавить счёт", | |||
There was a problem hiding this comment.
The translation "Добавить счёт" contains an incorrect letter 'ё'. In Russian, this should be "Добавить счет" with 'е' instead of 'ё' for consistency with modern Russian typography conventions.
| "addNewOrExisting" : "Добавить счёт", | |
| "addNewOrExisting" : "Добавить счет", |
Copilot uses AI. Check for mistakes.
| @@ -6841,7 +6986,7 @@ | |||
| }, | |||
| "selectAccount" : { | |||
| "title" : "выберите счёт", | |||
| "addAccount" : "Добавить ещё один счёт" | |||
| "addAccount" : "Добавить счёт" | |||
There was a problem hiding this comment.
The translation "Добавить счёт" contains an incorrect letter 'ё'. In Russian, this should be "Добавить счет" with 'е' instead of 'ё' for consistency with modern Russian typography conventions.
| "addAccount" : "Добавить счёт" | |
| "addAccount" : "Добавить счет" |
Copilot uses AI. Check for mistakes.
| @@ -6734,7 +6767,7 @@ | |||
| }, | |||
| "DeviceNotOnboardedDAError" : { | |||
| "title" : "Sua Ledger não está configurada", | |||
| "description" : "Configure para usá-lá. Vamos guiar você pelo processo de configuração.", | |||
| "description" : "Configure-a para usá-lá. Vamos guiar você pelo processo de configuração.", | |||
There was a problem hiding this comment.
There's a grammatical error in the Portuguese text. "usá-lá" should be "usá-la" (lowercase 'l'). The correct pronoun form requires a lowercase letter.
| "description" : "Configure-a para usá-lá. Vamos guiar você pelo processo de configuração.", | |
| "description" : "Configure-a para usá-la. Vamos guiar você pelo processo de configuração.", |
Copilot uses AI. Check for mistakes.
| "description" : "Configurez-le pour commencer à l’utiliser. Nous vous guiderons à chaque étape.", | ||
| "goToOnboardingButton" : "Configurer mon wallet", | ||
| "goToOnboardingButton" : "Configurer", | ||
| "goToOnboardingButtonWithProductName" : "Configurer mon {{ productName }}" |
There was a problem hiding this comment.
[nitpick] The French translation has been simplified from "Configurer mon wallet" to just "Configurer", but the corresponding line 6772 still shows "Configurer mon {{ productName }}". This inconsistency might confuse users about whether they're configuring a generic wallet or their specific product.
| "goToOnboardingButtonWithProductName" : "Configurer mon {{ productName }}" | |
| "goToOnboardingButtonWithProductName" : "Configurer" |
Copilot uses AI. Check for mistakes.
* File apps/ledger-live-desktop/static/i18n/en/app.json was translated to zh-CN locale * File apps/ledger-live-mobile/src/locales/en/common.json was translated to ru-RU locale * File apps/ledger-live-desktop/static/i18n/en/app.json was translated to de-DE locale * File apps/ledger-live-desktop/static/i18n/en/app.json was translated to th-TH locale * File apps/ledger-live-mobile/src/locales/en/common.json was translated to ar-AE locale * File apps/ledger-live-desktop/static/i18n/en/app.json was translated to fr-FR locale * File apps/ledger-live-desktop/static/i18n/en/app.json was translated to ko-KR locale * File apps/ledger-live-desktop/static/i18n/en/app.json was translated to ja-JP locale * File apps/ledger-live-desktop/static/i18n/en/app.json was translated to tr-TR locale * File apps/ledger-live-mobile/src/locales/en/common.json was translated to ko-KR locale * File apps/ledger-live-mobile/src/locales/en/common.json was translated to tr-TR locale * File apps/ledger-live-mobile/src/locales/en/common.json was translated to fr-FR locale * File apps/ledger-live-mobile/src/locales/en/common.json was translated to th-TH locale * File apps/ledger-live-desktop/static/i18n/en/app.json was translated to ru-RU locale * File apps/ledger-live-mobile/src/locales/en/common.json was translated to pt-BR locale * File apps/ledger-live-mobile/src/locales/en/common.json was translated to ja-JP locale * File apps/ledger-live-desktop/static/i18n/en/app.json was translated to ar-AE locale * File apps/ledger-live-mobile/src/locales/en/common.json was translated to de-DE locale * File apps/ledger-live-desktop/static/i18n/en/app.json was translated to es-ES locale * File apps/ledger-live-mobile/src/locales/en/common.json was translated to zh-CN locale * File apps/ledger-live-desktop/static/i18n/en/app.json was translated to pt-BR locale * File apps/ledger-live-mobile/src/locales/en/common.json was translated to es-ES locale --------- Co-authored-by: smartling-github-connector[bot] <165276057+smartling-github-connector[bot]@users.noreply.github.com>
Please review this manually triggered translation push from the configuration set 'ledger-live - json - Pull Request' in your Smartling project https://dashboard.smartling.com/app/projects/be90da906/github-connector/configurationSets/f7e47f48e176