Skip to content

Conversation

ejaycoleman
Copy link
Contributor

@ejaycoleman ejaycoleman commented Aug 14, 2025

✅ Checklist

  • npx changeset was attached.
  • Covered by automatic tests.
    • N/A - implements mocking to enable testing
  • Impact of the changes:
    • pnpm dev:lld:msw starts LLD with MSW to intercept mocks. Handlers defined in apps/ledger-live-desktop/src/mocks/browser.ts

📝 Description

Implements MSW for use within MAD/DADA development

Testing with #11334:

pnpm dev:lld pnpm dev:lld:msw
image image

❓ Context


🧐 Checklist for the PR Reviewers

  • The code aligns with the requirements described in the linked JIRA or GitHub issue.
  • The PR description clearly documents the changes made and explains any technical trade-offs or design decisions.
  • There are no undocumented trade-offs, technical debt, or maintainability issues.
  • The PR has been tested thoroughly, and any potential edge cases have been considered and handled.
  • Any new dependencies have been justified and documented.
  • Performance considerations have been taken into account. (changes have been profiled or benchmarked if necessary)

Copy link

vercel bot commented Aug 14, 2025

The latest updates on your projects. Learn more about Vercel for GitHub.

4 Skipped Deployments
Project Deployment Preview Comments Updated (UTC)
ledger-live-github-bot Ignored Ignored Preview Aug 21, 2025 11:11am
native-ui-storybook Ignored Ignored Preview Aug 21, 2025 11:11am
react-ui-storybook Ignored Ignored Preview Aug 21, 2025 11:11am
web-tools Ignored Ignored Preview Aug 21, 2025 11:11am

@live-github-bot live-github-bot bot added the desktop Has changes in LLD label Aug 14, 2025
@ejaycoleman ejaycoleman force-pushed the feat/LIVE-20566-msw-for-MAD branch 2 times, most recently from 5195de5 to c1643d7 Compare August 14, 2025 10:59
@ejaycoleman ejaycoleman marked this pull request as ready for review August 14, 2025 10:59
@ejaycoleman ejaycoleman requested a review from a team as a code owner August 14, 2025 10:59
@ejaycoleman ejaycoleman force-pushed the feat/LIVE-20566-msw-for-MAD branch from c1643d7 to 7608a7c Compare August 14, 2025 11:03
@ejaycoleman ejaycoleman marked this pull request as draft August 14, 2025 14:45
@ejaycoleman ejaycoleman force-pushed the feat/LIVE-20566-msw-for-MAD branch from 9558ebd to e60ad64 Compare August 14, 2025 15:13
@ejaycoleman ejaycoleman marked this pull request as ready for review August 14, 2025 15:15
@ejaycoleman ejaycoleman changed the title feat(LLD): mock fetch for mad dada feat(LLD): LLD MSW for MAD DADA Aug 14, 2025
@live-github-bot
Copy link
Contributor

live-github-bot bot commented Aug 14, 2025

Desktop Bundle Checks

Comparing f925ee7 against 0247bda.

⚠️ renderer bundle size significantly increased: 43.1mb -> 43.4mb. Please check if this is expected.
⚠️ outvariant library is now duplicated in renderer (regression)
⚠️ path-to-regexp library is now duplicated in renderer (regression)

@ejaycoleman ejaycoleman force-pushed the feat/LIVE-20566-msw-for-MAD branch 2 times, most recently from 40ff3cc to 9fa9877 Compare August 15, 2025 09:23
LucasWerey
LucasWerey previously approved these changes Aug 20, 2025
@ejaycoleman ejaycoleman force-pushed the feat/LIVE-20566-msw-for-MAD branch from f4e0168 to da8c8f2 Compare August 21, 2025 11:10
Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
0.0% Coverage on New Code (required ≥ 80%)

See analysis details on SonarQube Cloud

@ejaycoleman ejaycoleman merged commit f0d1043 into develop Aug 21, 2025
102 of 105 checks passed
@ejaycoleman ejaycoleman deleted the feat/LIVE-20566-msw-for-MAD branch August 21, 2025 12:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
desktop Has changes in LLD
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants