Skip to content

Conversation

cgrellard-ledger
Copy link
Contributor

✅ Checklist

  • npx changeset was attached.
  • Covered by automatic tests.
  • Impact of the changes:

📝 Description

Add NRR as a possible interest type for the ApyIndicator component
Also display a ~ in front of the percentage in the ApyIndicator component

❓ Context

  • JIRA or GitHub link:

🧐 Checklist for the PR Reviewers

  • The code aligns with the requirements described in the linked JIRA or GitHub issue.
  • The PR description clearly documents the changes made and explains any technical trade-offs or design decisions.
  • There are no undocumented trade-offs, technical debt, or maintainability issues.
  • The PR has been tested thoroughly, and any potential edge cases have been considered and handled.
  • Any new dependencies have been justified and documented.
  • Performance considerations have been taken into account. (changes have been profiled or benchmarked if necessary)

Copy link

vercel bot commented Aug 12, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

4 Skipped Deployments
Project Deployment Preview Comments Updated (UTC)
ledger-live-github-bot ⬜️ Ignored Aug 12, 2025 4:12pm
native-ui-storybook ⬜️ Ignored Aug 12, 2025 4:12pm
react-ui-storybook ⬜️ Ignored Aug 12, 2025 4:12pm
web-tools ⬜️ Ignored Aug 12, 2025 4:12pm

@live-github-bot live-github-bot bot added desktop Has changes in LLD mobile Has changes in LLM labels Aug 12, 2025
@cgrellard-ledger cgrellard-ledger merged commit cfe7201 into develop Aug 14, 2025
64 of 65 checks passed
@cgrellard-ledger cgrellard-ledger deleted the feat/add-nrr-to-apy-indicator branch August 14, 2025 12:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
desktop Has changes in LLD mobile Has changes in LLM
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants