Skip to content

Conversation

ysitbon
Copy link
Contributor

@ysitbon ysitbon commented Aug 12, 2025

✅ Checklist

  • npx changeset was attached.
  • Covered by automatic tests.
  • Impact of the changes:
    • ...

📝 Description

Fix the synthetic test reusable workflow condition that flag the release workflow as failed (even if not)

❓ Context

  • JIRA or GitHub link:

🧐 Checklist for the PR Reviewers

  • The code aligns with the requirements described in the linked JIRA or GitHub issue.
  • The PR description clearly documents the changes made and explains any technical trade-offs or design decisions.
  • There are no undocumented trade-offs, technical debt, or maintainability issues.
  • The PR has been tested thoroughly, and any potential edge cases have been considered and handled.
  • Any new dependencies have been justified and documented.
  • Performance considerations have been taken into account. (changes have been profiled or benchmarked if necessary)

@ysitbon ysitbon requested a review from a team as a code owner August 12, 2025 15:03
@live-github-bot live-github-bot bot added the automation CI/CD stuff label Aug 12, 2025
Copy link

vercel bot commented Aug 12, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

4 Skipped Deployments
Project Deployment Preview Comments Updated (UTC)
ledger-live-github-bot ⬜️ Ignored Aug 12, 2025 3:04pm
native-ui-storybook ⬜️ Ignored Aug 12, 2025 3:04pm
react-ui-storybook ⬜️ Ignored Aug 12, 2025 3:04pm
web-tools ⬜️ Ignored Aug 12, 2025 3:04pm

Copy link
Contributor

github-actions bot commented Aug 12, 2025

❌ Action Required: Monitored Files Changed

The following files in monitored folders have been modified:

  • .github/workflows/test-mobile-synthetics-reusable.yml

Action Required: Please rebase your branch against develop to ensure consistency:

git rebase origin/develop

@ysitbon ysitbon changed the title chore: fix reusable workflow bool condition chore: fix synthetic tests reusable workflow bool condition Aug 12, 2025
@ysitbon ysitbon merged commit aa775ac into develop Aug 25, 2025
45 of 49 checks passed
@ysitbon ysitbon deleted the chore/synthetic-workflow-bool-condition branch August 25, 2025 08:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants