Skip to content

Conversation

hhumphrey-ledger
Copy link
Contributor

@hhumphrey-ledger hhumphrey-ledger commented Aug 12, 2025

📝 Description

Using navigation.popToTop works in buy/sell as we have no additional routing within the app so it is not intercepted by this listener and it successfully goes back to the homepage

Swap has additional routing and our history stack can get messy. Doing:

navigation.getParent()?.navigate(NavigatorName.Base, {
    screen: NavigatorName.Main,
});

Forces us to load the main screen and unload swap

❓ Context


🧐 Checklist for the PR Reviewers

  • The code aligns with the requirements described in the linked JIRA or GitHub issue.
  • The PR description clearly documents the changes made and explains any technical trade-offs or design decisions.
  • There are no undocumented trade-offs, technical debt, or maintainability issues.
  • The PR has been tested thoroughly, and any potential edge cases have been considered and handled.
  • Any new dependencies have been justified and documented.
  • Performance considerations have been taken into account. (changes have been profiled or benchmarked if necessary)

@hhumphrey-ledger hhumphrey-ledger requested a review from a team as a code owner August 12, 2025 15:03
@live-github-bot live-github-bot bot added the mobile Has changes in LLM label Aug 12, 2025
Copy link

vercel bot commented Aug 12, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

4 Skipped Deployments
Project Deployment Preview Comments Updated (UTC)
ledger-live-github-bot ⬜️ Ignored Preview Aug 13, 2025 0:49am
native-ui-storybook ⬜️ Ignored Preview Aug 13, 2025 0:49am
react-ui-storybook ⬜️ Ignored Preview Aug 13, 2025 0:49am
web-tools ⬜️ Ignored Preview Aug 13, 2025 0:49am

@hhumphrey-ledger hhumphrey-ledger merged commit 05bda3f into develop Aug 13, 2025
52 checks passed
@hhumphrey-ledger hhumphrey-ledger deleted the fix/ptx-custom-close branch August 13, 2025 13:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
mobile Has changes in LLM
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants